Skip to main content
Share Your Experience: Take the 2024 Developer Survey
23 votes

Etiquette for an incorrect Pull Request

Oops, my bad. Everything was correct after all. seems absolutely fine to me. You could add "sorry for the distraction" or similar if you wanted to.
Philip Kendall's user avatar
22 votes
Accepted

Is it legal to remove a contributor's name from the licence?

No, it is not legal to remove the copyright notice of a contributor who has offered a copyrightable contribution under the MIT license. Jeff has offered his work to Mark under the MIT license and Mark ...
apsillers's user avatar
  • 36.2k
21 votes

Who owns contributed code?

You own any code that you write. When you contribute to projects you aren't handing over your copyright (ownership), you're giving them a license to your work. It's usually inferred to be the same ...
Seth Falco's user avatar
15 votes
Accepted

Who is responsible on resolving conflicts on different PRs?

That's a tricky question for the maintainers / core devs to answer and there cannot be "the one correct answer" as it depends highly on how that particular community works and how the people talk to ...
planetmaker's user avatar
  • 11.2k
15 votes
Accepted

Do Contributors Own Copyright After Sending Contributions?

The common understanding is to consider that contributions are made under the same license as the project these are contributed to (unless stated otherwise). On GitHub, this is made explicit in the ...
Philippe Ombredanne's user avatar
15 votes

Etiquette for an incorrect Pull Request

To add to Philip Kendall's answer: After explaining and/or apologizing, don't leave the PR open. If you agree it's fundamentally redundant, close it yourself:
Mureinik's user avatar
  • 5,142
14 votes
Accepted

What should I do if maintainers are unresponsive/how can I become a maintainer?

The primary way to contribute is by pull requests, just like you said. If your pull requests aren't accepted and you do not get any comments the project might as well be abandoned. In this case I ...
jgauffin's user avatar
  • 441
13 votes
Accepted

Can I resubmit someone else's pull request if he does not sign CLA?

This depends in part on what the CLA requires, but it may be possible. Do you have the ability to reuse the submission at all? In general, it's understood that contributions to an open source ...
apsillers's user avatar
  • 36.2k
13 votes

When folks send me pull-requests on GitHub, what are their copyright/licensing terms by default?

Update, based on new Terms of Service: If a GitHub repository specifies a license, that's the default license for contributions. Here's Section D.6 from GitHub's current Terms of Service: 6. ...
jkdev's user avatar
  • 395
11 votes
Accepted

When folks send me pull-requests on GitHub, what are their copyright/licensing terms by default?

Some GPL projects require explicit copyright assignment, not merely licensing, of contributions. Copyright assignment is a bigger deal that licensing, and perhaps can't be arranged by an Apache style '...
bmargulies's user avatar
  • 4,267
10 votes
Accepted

Etiquette for an incorrect Pull Request

Your suggested sentence is fine. If you want, you can also thank the other person for spotting your mistake and explain why you were mistaken. If you made the mistake, others might as well - after ...
Heinzi's user avatar
  • 566
8 votes

Etiquette for an incorrect Pull Request

"Oops, I was mistaken, sorry! Thanks for your time."
ScottishTapWater's user avatar
7 votes
Accepted

Can a LGPL project use contributed code after the original contributor withdrew it and was banned from the project?

There doesn't seem to be a copyright violation here. The code was pretty clearly released under the LGPL, and open source licenses are (almost certainly) irrevocable; it doesn't matter that the patch ...
Philip Kendall's user avatar
7 votes
Accepted

Is it in line with the DCO that a github sign-off needs and publishes full name + an email "that matches the commit author"?

Some projects such as Linux ask for the DCO to be signed in order to do due diligence, and ultimately to protect downstream users. The DCO does not forbid projects from establishing individual ...
amon's user avatar
  • 39k
6 votes
Accepted

Can I use an unmerged pull request to an Apache 2.0 project in my proprietary fork?

Not only do GitHub's terms of service codify that the submission would be covered under the Apache 2 license, so too does the Apache 2 license itself: "Contribution" shall mean any work of ...
apsillers's user avatar
  • 36.2k
6 votes

When folks send me pull-requests on GitHub, what are their copyright/licensing terms by default?

In case of doubt, you should state clearly that you only accept contributions under GPLv3 (or whatever license you select), and that the constributor must make sure they are allowed to contribute ...
vonbrand's user avatar
  • 5,267
5 votes

How to ensure the license for GitHub PRs?

I found a service https://cla-assistant.io, recommended by https://cla.github.com. Makes a hook to ensure every contributor signs the CLA. Looks good so far. Will try and see how it goes.
Ilya Kantor's user avatar
5 votes

What should I do if maintainers are unresponsive/how can I become a maintainer?

Although @jgauffin is giving you good general guidelines, I would add that it is important not to jump to conclusions too quickly. In your question, you say that you haven't received any response for ...
Zimm i48's user avatar
  • 5,597
4 votes

Can I use an unmerged pull request to an Apache 2.0 project in my proprietary fork?

Pull from the fork, not from the PR itself. The PR must be coming from another GitHub repo which would be a fork of the main one. That fork must also have a LICENSE file along with commits you are ...
rvs's user avatar
  • 473
4 votes

Is it acceptable to change the implementation language in a pull request?

is it acceptable to change the implementation language via pull request? Everything is "acceptable" for you to propose... but not everything may be accepted. If you were to submit a PR to one of my ...
Philippe Ombredanne's user avatar
4 votes
Accepted

Relicensing from GPLv3 to GPLv2

Since others have written code for the project, I believe they also have a small claim in the copyright of the project as a whole. Without a consensus of all copyright holders, I don't believe you are ...
airfishey's user avatar
  • 1,904
3 votes

How could a large open source project manage the Pull Requests?

Large bazaar-style open source projects usually don't just have one but many maintainers who review pull requests. Those often specialize in specific sub-modules of the application, so they have a ...
Philipp's user avatar
  • 11.9k
3 votes
Accepted

Need feature in PR with failing checks

To resolve this problem you can fork the version that includes a feature that you need and resolve the check problem. After that you can submit the PR with your changes. An example: There exist a ...
vincenzopalazzo's user avatar
3 votes

Who is responsible on resolving conflicts on different PRs?

As @planetmaker pointed out, every one has their opinions. But weighing in my $.02, it's usually first raised first merged. So, whoever raised it later has to work on merging it in. The reason for ...
N.N.Karthik's user avatar
3 votes

Relicensing from GPLv3 to GPLv2

When receiving contributions to a project, the default assumption is that the contribution is under the same licence as the project itself. The main exceptions are when the contribution explicitly ...
Bart van Ingen Schenau's user avatar
3 votes
Accepted

How to require contributor to agree BEFORE creating a pull request?

Try the CLA Assistant webhook. https://cla-assistant.io/ is a free service which has you simply: Save your CLA at gist.github.com. Give a title and the text. Point the hook at your repo. Do the link ...
Frugal Guy's user avatar
3 votes

How to require contributor to agree BEFORE creating a pull request?

Solution on a tangent: maintain a list of people who agreed to your CLA. This could be done in a separate file which also pull request could be made for by adding their name. Automatically check for ...
planetmaker's user avatar
  • 11.2k
3 votes
Accepted

Can I send a pull request of a License file to a project?

As we have already said, since there is no licence attached to this code, the starting position is that you have no rights to copy or use it. However, as we have also noted, GitHub's terms of service ...
MadHatter's user avatar
  • 49.2k
3 votes
Accepted

What are the implications of accepting pull-requests to an AGPLv3 project under the same license?

Is it correct that I will now have to publish any further changes made to the project? No. But if you choose to distribute it, you will be obliged to fulfil the licence's obligations, including ...
MadHatter's user avatar
  • 49.2k

Only top scored, non community-wiki answers of a minimum length are eligible