Questions tagged [pull-request]
The pull-request tag has no usage guidance.
24
questions
12
votes
4
answers
3k
views
Etiquette for an incorrect Pull Request
I recently made a PR on GitHub to a repo of a tutorial since I thought one of the comments was incorrect; but I was mistaken.
One of the contributors commented asking how it was incorrect. What's the ...
- 123
15
votes
2
answers
5k
views
Is it legal to remove a contributor's name from the licence?
User Mark makes repository A and releases the code under the MIT license with their name in the license. User Jeff forks the repository makes some improvements and adds their name to the license file (...
- 153
2
votes
2
answers
214
views
How to require contributor to agree BEFORE creating a pull request?
Does anyone have a solution to the problem below?
Yes, I can reject at review time, but I'd rather have that taken care of prior to reviewing the PR.
Do we know if github will support yml for pull ...
- 59
4
votes
0
answers
62
views
Does a BSD-3 repository own Pull Requests?
I submit a large PR to repository X. Later, I close the PR and make my own repository that uses some of X's code, and give X due attribution in the NOTICE file and function docstrings. At time of ...
2
votes
1
answer
157
views
Can I send a pull request of a License file to a project?
I found an open issue in a GitHub repository requesting a permissive license for the project to be used by other people. It was answered by saying that they will put an MIT License, but was not done ...
- 33
2
votes
1
answer
134
views
What are the implications of accepting pull-requests to an AGPLv3 project under the same license?
Say I publish a project under AGPLv3 terms with a LICENSE.md and code headers stating the terms, the year and the author. From what I understand, I am the sole licensor of this project and not bound ...
- 203
5
votes
3
answers
159
views
Can I use an unmerged pull request to an Apache 2.0 project in my proprietary fork?
There's a project under Apache 2.0 which has an abondoned pull request. I plan to use this code, fix it and merge into my proprietary fork of the main project. This fork is a part of a bigger ...
- 53
2
votes
2
answers
133
views
How could a large open source project manage the Pull Requests?
I was thinking about a very complicated GitHub open source project, how to manage pull requests. For example, here there are close to a thousand pull requests .
How could the k8s administrator ...
- 139
3
votes
1
answer
161
views
Can a LGPL project use contributed code after the original contributor withdrew it and was banned from the project?
"Project A" is released under LGPL ver 2.1 or, at user's discretion, above. This project is part of a bigger platform.
"Contributor A" submitted a highly-popular merge request to ...
- 297
1
vote
1
answer
485
views
Is it in line with the DCO that a github sign-off needs and publishes full name + an email "that matches the commit author"?
This is a full copy from https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name
########
Coming from Stack Overflow where a pseudo ...
- 121
11
votes
1
answer
2k
views
Who owns contributed code?
So, I contribute to a few projects, but the code I contribute is from ideas for my own projects.
So let's say I have Project A, and a competitor has Project B. I contribute code I wrote to Project B, ...
- 111
4
votes
1
answer
79
views
Need feature in PR with failing checks
An open source software I am using has a pull request for a feature that I need, but it has never been merged due to failing checks.
Instead of implementing the feature myself, is there any way that ...
- 43
12
votes
2
answers
2k
views
Who is responsible on resolving conflicts on different PRs?
I'm the owner of the code in github and responsible of merging PRs in the main upper stream. I have two different PRs from different two contributers which have conflicts in some files. Who is ...
- 123
5
votes
1
answer
150
views
How to ensure the license for GitHub PRs?
My GitHub repository is licensed with CC BY-SA license.
When people suggest PRs, and I accept them, do they automatically fall under the same license as the rest of the project?
If not, how can I ...
- 201
10
votes
1
answer
2k
views
Do Contributors Own Copyright After Sending Contributions?
I have a GitHub repository which its license is GPL. Although of this, in the "about" window of my program, I mentioned that I own the copyright (like this: © My name, 2017). And I added the GPL text ...
- 235
1
vote
0
answers
796
views
What happens if I do not add a license to my open source project on Github? [duplicate]
I just received a notification about the following issue from a project I contributed in the past: Can it be a open source project? (Since the source code is already open, I think the title should be ...
- 243
13
votes
1
answer
416
views
Can I resubmit someone else's pull request if he does not sign CLA?
Someone helped with progress upstream at an open source project I really rely on. He basically did what I was not capable of and now I am waiting for his pull request to be merged and included in ...
- 243
5
votes
2
answers
113
views
Is it acceptable to change the implementation language in a pull request?
I would submit a pull request updating a library or a language. I would do so even if there are breaking changes (ex. Python 2 -> Python 3). I would submit a pull request that adds a new library if ...
- 161
2
votes
2
answers
282
views
Relicensing from GPLv3 to GPLv2
I have an open source project on GitHub released under GPL3. I want to re-license it under GPL2. 99.9% of the program is written by me, only few lines of code is written by other people.
Can I re-...
- 235
14
votes
2
answers
2k
views
What should I do if maintainers are unresponsive/how can I become a maintainer?
I have just a couple years of experience in software development and in the past few months have been dipping my toes in the water of making open source contributions. It was very exciting when my ...
- 243
29
votes
3
answers
4k
views
When folks send me pull-requests on GitHub, what are their copyright/licensing terms by default?
Say I'm maintaining a GPLv3 project on GitHub with a LICENSE file, code headers and all. Now, a few folks made some code enhancements and sent me a pull-request. Does that automatically mean that they ...
- 995
6
votes
2
answers
618
views
Pull request ownership, who owns the code committed?
Say I create an Open Source project on Github licensed under e.g. LGPL like Qt. As I understand ownership of code, if I wrote a piece of code, I am free to change the license at a later point, as long ...
- 163
9
votes
5
answers
1k
views
How can I know how much of a change to make in each of my pull requests?
When contributing to an open source project that uses pull requests exclusively for contributions, I'm left wondering when a good time is for me to send a pull request.
I'm especially in doubt when ...
- 2,100
25
votes
4
answers
27k
views
What exactly is a pull request?
This branched out from my previous question: Can I select who can contribute to my Open Source Project?
Having never worked on open source software before, and developing my own mini applications ...
- 6,389