Open Source Stack Exchange is a question and answer site for people organizing, marketing or licensing open source development projects. It only takes a minute to sign up.
Sign up to join this community
I recently made a PR on GitHub to a repo of a tutorial since I thought one of the comments was incorrect; but I was mistaken.
One of the contributors commented asking how it was incorrect. What's the correct way to say "Oops, my bad. Everything was correct after all"?
Your suggested sentence is fine.
If you want, you can also
If you made the mistake, others might as well - after all, you mentioned that the repo is a tutorial, and tutorials are aimed at beginners. Maybe there's a way to improve the tutorial so that others won't make the same mistake you did?
Oops, my bad. Everything was correct after all!
I initially thought that foo needed to be initialized to avoid frobnicating the bar, but after reading your comment and re-reading the code I realized that baz was explicitly designed to handle uninitialized foos. Thanks for spotting my mistake.
Oops, my bad. Everything was correct after all.
seems absolutely fine to me. You could add "sorry for the distraction" or similar if you wanted to.
To add to Philip Kendall's answer: After explaining and/or apologizing, don't leave the PR open. If you agree it's fundamentally redundant, close it yourself:
"Oops, I was mistaken, sorry! Thanks for your time."
