12

I recently made a PR on GitHub to a repo of a tutorial since I thought one of the comments was incorrect; but I was mistaken.

One of the contributors commented asking how it was incorrect. What's the correct way to say "Oops, my bad. Everything was correct after all"?

1
  • 1
    Thanks for the points everyone made. I chose to write: "Oops, my bad. Everything was correct after all. Thanks for your time" and close the PR. A colleague suggested that it's better to end on a positive note instead of something like "Sorry/aplologies".
    – Sh.A
    Sep 8, 2022 at 17:28

4 Answers 4

10

Your suggested sentence is fine.

If you want, you can also

  • thank the other person for spotting your mistake and
  • explain why you were mistaken.

If you made the mistake, others might as well - after all, you mentioned that the repo is a tutorial, and tutorials are aimed at beginners. Maybe there's a way to improve the tutorial so that others won't make the same mistake you did?

Oops, my bad. Everything was correct after all!

I initially thought that foo needed to be initialized to avoid frobnicating the bar, but after reading your comment and re-reading the code I realized that baz was explicitly designed to handle uninitialized foos. Thanks for spotting my mistake.

1
  • 4
    Excellent! It will even be helpful if this comment is not acted upon as even then it might be found by others with identical or similar thoughts in the issue history of the project. Sep 5, 2022 at 12:40
23

Oops, my bad. Everything was correct after all.

seems absolutely fine to me. You could add "sorry for the distraction" or similar if you wanted to.

15

To add to Philip Kendall's answer: After explaining and/or apologizing, don't leave the PR open. If you agree it's fundamentally redundant, close it yourself:

enter image description here

0
8

"Oops, I was mistaken, sorry! Thanks for your time."

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Not the answer you're looking for? Browse other questions tagged or ask your own question.